core(driver): checkForQuiet bugfix to properly handle setTimeout() #16155
Conversation
Can you describe this bug in a bit more detail? If the target page is closed then a crash seems perfectly reasonable to me. |
In my particular case, I'm not using lighthouse as a cli tool, I'm calling gotoURL() directly, so I want to handle this exception gracefully and wind down correctly. Right now - node just exits. |
|
Using |
aguidrevitch
force-pushed
the
bugfix/check-for-quiet-unhandled-rejection
branch
from
79ba5a4 to
8b3b88a
Compare
|
@aguidrevitch is this still a problem for you? While the fix here looks reasonable, we have some hesitance about introducing changes to such a core part of our workflow and we're not ready to absorb the maintenance fallout. So we're going to reject this for now, but if we are revisiting this file, we'll likely try pulling this in during a larger refactor. Apologies and thank you. |
Summary
The PR fixes unhandled rejections which happen in setTimeout(checkForQuiet).
It is a bugfix.
When target page gets closed during waitForCPUIdle, lighthouse crashes.